Skip to content

fix: again. use correct tag #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

fix: again. use correct tag #303

merged 1 commit into from
Apr 4, 2025

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 4, 2025

either one passed in or github.ref for publish
saved as TAG_NAME. use TAG_NAME. :headdesk:

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

@jmeridth jmeridth self-assigned this Apr 4, 2025
@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 06:03
@jmeridth jmeridth requested a review from a team as a code owner April 4, 2025 06:03
@github-actions github-actions bot added the fix label Apr 4, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request aims to fix the tagging mechanism in the major version updater workflow by ensuring the correct tag is used.

  • Adjusts the tagging command in the GitHub Actions workflow
  • Introduces conflict markers indicating unresolved merge conflicts

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

either one passed in or github.ref for publish
saved as TAG_NAME.  use TAG_NAME. :headdesk:

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth merged commit 59a313b into main Apr 4, 2025
9 checks passed
@jmeridth jmeridth deleted the jm_head_desk branch April 4, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant