fix: get tags with checkout #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jmeridth <jmeridth@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug fix related to fetching and tagging versions correctly during the checkout process.
- The checkout action now fetches tags by adding "with: fetch-tags: true".
- The git tag command has been updated to use the output "steps.version.outputs.tag" instead of the previously used "TAG_NAME".
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
Comment on lines
29
to
33
| { echo "tag=${tag}"; echo "version=${version}"; echo "major=${major}"; } >> "$GITHUB_OUTPUT" | ||
| - name: force update major tag | ||
| run: | | ||
| git tag v${{ steps.version.outputs.major }} ${TAG_NAME} | ||
| git tag v${{ steps.version.outputs.major }} ${{ steps.version.outputs.tag }} | ||
| git push -f origin v${{ steps.version.outputs.major }} |
There was a problem hiding this comment.
Confirm that 'steps.version.outputs.tag' is correctly set in the previous steps, as this change replaces the usage of TAG_NAME and could lead to unintended version tagging if not properly defined.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenanceorbreaking