Skip to content

feat: phase 1 changes: add comments feat to unchanged lines in the pullrequest #32471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 62 commits into
base: main
Choose a base branch
from

Conversation

rajesh-jonnalagadda
Copy link

@rajesh-jonnalagadda rajesh-jonnalagadda commented Nov 11, 2024

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 11, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Nov 11, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
@rajesh-jonnalagadda rajesh-jonnalagadda force-pushed the feat-32257-add-comments-unchanged-lines-and-show branch 2 times, most recently from e59800b to ed80303 Compare November 11, 2024 02:46
@rajesh-jonnalagadda rajesh-jonnalagadda force-pushed the feat-32257-add-comments-unchanged-lines-and-show branch from ed80303 to abd1d2f Compare November 11, 2024 03:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as draft November 11, 2024 16:59
@rajesh-jonnalagadda rajesh-jonnalagadda force-pushed the feat-32257-add-comments-unchanged-lines-and-show branch from 8c34f45 to 7c39ad2 Compare November 11, 2024 17:27
@rajesh-jonnalagadda rajesh-jonnalagadda force-pushed the feat-32257-add-comments-unchanged-lines-and-show branch from 3fbf96f to ccd797a Compare November 11, 2024 17:50
@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as ready for review November 11, 2024 18:29
@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as draft November 11, 2024 19:19
@rajesh-jonnalagadda rajesh-jonnalagadda marked this pull request as ready for review November 11, 2024 23:56

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
@rajesh-jonnalagadda
Copy link
Author

@lunny Can you please review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
@rajesh-jonnalagadda
Copy link
Author

@lunny Could you please review my changes? If the PR isn't relevant, feel free to close it.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
@lunny
Copy link
Member

lunny commented Nov 13, 2024

@lunny Could you please review my changes? If the PR isn't relevant, feel free to close it.

I will review it in the following week.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
rajesh-jonnalagadda and others added 7 commits December 10, 2024 12:54
…thub.com:rajesh-jonnalagadda/gitea into feat-32257-add-comments-unchanged-lines-and-show

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
@rajesh-jonnalagadda
Copy link
Author

@lunny Do we need these changes?

@lunny
Copy link
Member

lunny commented Jan 27, 2025

@lunny Do we need these changes?

Hi, #32471 (comment) hasn't been updated and there are many changes and conflicts.

rajesh-jonnalagadda and others added 5 commits February 21, 2025 10:33

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
…thub.com:rajesh-jonnalagadda/gitea into feat-32257-add-comments-unchanged-lines-and-show
@rajesh-jonnalagadda
Copy link
Author

rajesh-jonnalagadda commented Mar 2, 2025

@lunny resolved the conflicts and removed the j-query part. can you please review

@rajesh-jonnalagadda rajesh-jonnalagadda force-pushed the feat-32257-add-comments-unchanged-lines-and-show branch from 03493b9 to ebad7a3 Compare March 2, 2025 10:46

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
@rajesh-jonnalagadda
Copy link
Author

@lunny can please review the pr

rajesh-jonnalagadda and others added 3 commits March 5, 2025 10:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
@rajesh-jonnalagadda
Copy link
Author

@lunny can please review the pr

@lunny ^^

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…show
@rajesh-jonnalagadda
Copy link
Author

@lunny can you please review?

@rajesh-jonnalagadda
Copy link
Author

@lunny can you please review?

@lunny do we need these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants