Allow for embedded images in markdown #394
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This will add support for markdown that contains images as a base64 encoded string within the markdown syntax. Typically this is seen like the following:
Approach
The approach taken is to mirror what is being done by
ImageProvider
andInlineImageProvider
but to allow for when the source is a string rather than a urlCaveats
Would love some help and feedback on the following to make sure the changes are appropriate