Skip to content

Allow for embedded images in markdown #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cuteiosdev
Copy link

Purpose

This will add support for markdown that contains images as a base64 encoded string within the markdown syntax. Typically this is seen like the following:

![Embedded markdown image]("data:image/png;base64,...")

Approach

The approach taken is to mirror what is being done by ImageProvider and InlineImageProvider but to allow for when the source is a string rather than a url

Caveats

Would love some help and feedback on the following to make sure the changes are appropriate

  • Adding to demo project
  • Unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant