Simplify Rust code #1070
Open
Simplify Rust code #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to google#1055 we have `mid_size == 0` and `use_inputs_at_offsets == false`. This simplifies the code significantly. The simplification is fine to do because we only support one model and it's embedded. Once we'll support multiple models (in particular dynamic loading), we'll need features extraction to work for all possible models (possibly having multiple features extraction functions).
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #1055 we have
mid_size == 0anduse_inputs_at_offsets == false. This simplifies the code significantly. The simplification is fine to do because we only support one model and it's embedded. Once we'll support multiple models (in particular dynamic loading), we'll need features extraction to work for all possible models (possibly having multiple features extraction functions).