Skip to content

fix: prevent panic when ContentLength is negative in Distributor RequestBodyTooLarge metrics (backport k249) #17066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: k249
Choose a base branch
from

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Apr 8, 2025

Backport 9e9f534 from #17054


What this PR does / why we need it:

re:

We encountered an edge case where Distributors panic when trying to increment their DiscardedBytes metrics for large request bodies:

panic: counter cannot decrease in value

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

…estBodyTooLarge metrics (#17054)

(cherry picked from commit 9e9f534)
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner April 8, 2025 17:49
@loki-gh-app loki-gh-app bot added backport component/distributor size/M type/bug Somehing is not working as expected labels Apr 8, 2025
@loki-gh-app loki-gh-app bot requested a review from JordanRushing April 8, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant