Skip to content

chore: implement multi-variant extractor that can return multiple samples #17149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: refactor-extractors-multiple-samples
Choose a base branch
from

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

This PR builds on #17064 and creates the Multi-Variant extractor capable of producing multiple samples per log line, one per variant. This new extractor is able to cache the result of the pipeline steps in common to the variants, allowing the extraction steps to do significantly less work.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney force-pushed the multi-variant-multiple-sample-extractor branch from 245924c to c9242f5 Compare April 11, 2025 20:41
@trevorwhitney trevorwhitney changed the title chore: update base refactor-extractors-multiple-samples chore: implement multi-variant extractor that can return multiple samples Apr 11, 2025
@trevorwhitney trevorwhitney marked this pull request as ready for review April 11, 2025 20:50
@trevorwhitney trevorwhitney requested a review from a team as a code owner April 11, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant