refactor(stringlabels): Support stringlabels in log.StreamPipeline #17216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeschkies
commented
Apr 14, 2025
| @@ -87,7 +87,7 @@ func (d *DeleteRequest) FilterFunction(lbls labels.Labels) (filter.Func, error) | |||
| return false | |||
| } | |||
|
|
|||
| result, _, skip := f(0, s, structuredMetadata...) | |||
| result, _, skip := f(0, s, labels.Labels(structuredMetadata)) // TODO: is this a copy? | |||
There was a problem hiding this comment.
@chaudum it should only make a copy of the slice header, right?
jeschkies
commented
Apr 14, 2025
| func (b *LabelsBuilder) Add(category LabelCategory, labels ...labels.Label) *LabelsBuilder { | ||
| for _, l := range labels { | ||
| func (b *LabelsBuilder) Add(category LabelCategory, lbs labels.Labels) *LabelsBuilder { | ||
| lbs.Range(func(l labels.Label) { |
There was a problem hiding this comment.
Should we benchmark this?
There was a problem hiding this comment.
› benchstat before.log after.log
goos: darwin
goarch: arm64
pkg: github.com/grafana/loki/v3/pkg/logql/log
cpu: Apple M2 Pro
│ before.log │ after.log │
│ sec/op │ sec/op vs base │
LabelsBuilder_Add/size_10-10 186.5n ± 0% 204.5n ± 2% +9.65% (p=0.000 n=10)
LabelsBuilder_Add/size_100-10 8.262µ ± 2% 9.049µ ± 1% +9.53% (p=0.000 n=10)
LabelsBuilder_Add/size_1000-10 769.8µ ± 0% 786.9µ ± 2% +2.22% (p=0.000 n=10)
LabelsBuilder_Add/size_10000-10 76.47m ± 0% 76.54m ± 0% ~ (p=0.739 n=10)
geomean 97.59µ 102.7µ +5.28%
So range is around 10%.
chaudum
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a next step of support Prometheus
stringlabelsimplementation in Loki. It adds support inlog.StreamPipeline.Special notes for your reviewer:
The tests should compile with build tag
stringlabels.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR