fix: fix bug where expectedStreamUsageRequest was not used #17223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,10 +177,10 @@ func TestFrontend_ExceedsLimits(t *testing.T) { | |||
| // and instance 1 for the data for partition 1. | |||
| expectedStreamUsageRequest: []*logproto.GetStreamUsageRequest{{ | |||
| Tenant: "test", | |||
| StreamHashes: []uint64{0x1, 0x2}, | |||
| StreamHashes: []uint64{0x2}, | |||
There was a problem hiding this comment.
Here is the main fix. When we stopped sending the partition ID in GetStreamusageRequest, we started sending just the stream hashes for the owned partitions, instead of all stream hashes. However, because expectedStreamUsageRequest was not being used in the test, this was never asserted. This test should have failed when we made the change a couple weeks ago.
6 tasks
grobinson-grafana
changed the title
periklis
approved these changes
Apr 15, 2025
grobinson-grafana
added a commit
that referenced
this pull request
Apr 15, 2025
chaudum
pushed a commit
that referenced
this pull request
Apr 15, 2025
Contains backports of these commits: ``` 2cde9b1 fix: skip streams over limits in dry-run mode (#17114) 805125c fix: fix a bug where limits were incorrect after #16937 (#17224) d106042 fix: fix bug where expectedStreamUsageRequest was not used (#17223) 69aeda1 feat: add tests for enforcing limits in distributors (#17124) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix bug where
expectedStreamUsageRequestwas not used in the tests for the limits-frontend.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR