Use BatchSeriesRefs() to create incoming series in one batch instead of one by one
#11019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colega
force-pushed
the
use-batchappender-batchseriesrefs-
branch
3 times, most recently
from
c9202f1 to
50b067c
Compare
colega
force-pushed
the
use-batchappender-batchseriesrefs-
branch
2 times, most recently
from
939ce46 to
eabfd1a
Compare
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
force-pushed
the
use-batchappender-batchseriesrefs-
branch
from
eabfd1a to
17810a8
Compare
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
changed the title
BatchSeriesRefs() to create incoming series in one batch instead of one by one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a proof-of-concept built on top of grafana/mimir-prometheus#860
It leverages the new BatchAppender that has a BatchSeriesRefs method that can create multiple series in a single call.
Background
Whenever a tenant has lots of series churn, or especially when ingesters start receiving series after a while (after startup or going out of read only mode), we see lots of mutex contention on
MemPostingsas hundreds and thousands of calls toMemPostings.Addoccur, each one trying to acquire the lock.I tried optimizing that with no luck in the past, this is yet another try.
This leverages a new method in
headAppenderthat will allow us creating all series at once.