fix(helm): fix indent for alertmanager-dep.yaml extraVolumes #11202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for the PR. The changes look good to me. While you're in the context of the problem, could you check other similar places in the chart — specifically in |
vincentbernaud
force-pushed
the
patch-helm-alertmanager
branch
from
822155c to
cfb9923
Compare
Hi @narqo, thanks for the review. I looked at the whole chart and I did find the same issue in graphite-proxy querier and write_proxy. I updated the PR to fix it too. |
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes a helm templating issues when running alertmanager as a deployment and extraVolumes are set either in global or alertmanager sections.
Which issue(s) this PR fixes or relates to
Fixes #9775
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.