-
Notifications
You must be signed in to change notification settings - Fork 581
MQE improve memory consumption estimate with Label information #11203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't quite what I had in mind: I think we need to accurately account for the size of labels given they can vary wildly, and we need to track this for anything that contains labels (SeriesMetadata
slices being the main missing source not yet accounted for).
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Yes I am thinking about this too, but I started only with this estimate, because to track the size labels accurately, it means we need to move the call to
To be honest, I didn't think about this. Will add this. Do you think there is additional place where labels are used apart of |
What this PR does
Add memory consumption estimate with Label information. The estimation is based on the following:
labels.Label
struct (32 bytes).I will try to figure out to improve the guesstimate of the two averages above by looking at the ops data.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.