MQE: include query planning and materialization in activity tracker #11212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/mqe-query-planner-activity-tracker
branch
from
7f71136 to
3041797
Compare
56quarters
approved these changes
Apr 15, 2025
pkg/streamingpromql/engine_test.go
Outdated
| queryTrackingTestingQueryable.activeQueryAtQueryTime = trackedQuery{} | ||
|
|
||
| q, err := createQuery(expr) | ||
| for _, usePlanner := range []bool{true, false} { |
There was a problem hiding this comment.
Personal preference so feel free to ignore, but I'm not a fan of tests that end up nested like this with multiple on/off conditionals. Instead I try to split the conditionals into top-level tests and create helpers for the shared setup / teardown.
There was a problem hiding this comment.
How's this? c9482af
charleskorn
force-pushed
the
charleskorn/mqe-query-planner-activity-tracker
branch
from
c9482af to
a030611
Compare
|
Given the approval, I'm going to merge this, but let me know if you have any feedback on my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR changes the behaviour of MQE to create activity tracker entries while running planning or materialization (converting a query plan to operators).
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.