MQE Series Metadata memory tracker #11219
Draft
+159
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
charleskorn
reviewed
Apr 14, 2025
Comment on lines
223
to
227
| if sm, isSeriesMetadata := any(s).(SeriesMetadata); isSeriesMetadata { | ||
| for _, l := range sm.Labels { | ||
| estimatedBytes += uint64(len(l.Name)+len(l.Value)) * StringSize | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we should tackle incorporating the label memory consumption in a separate PR - this will require a number of changes in a number of places, not just in this pools like this.
It may also be worthwhile raising a Prometheus PR to add something like a ByteSize() method to labels.Labels, so we can cheaply get the size of a labels.Labels without iterating over all the labels like this.
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.