Parquet: move readTsdb to parquet storage sub-package; rename method & vars for clarity & testability #11222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoposa
requested review from
npazosmendez and
jesusvazquez
and removed request for
a team and
npazosmendez
jesusvazquez
approved these changes
Apr 15, 2025
jesusvazquez
deleted the
francoposa/refactor-tsdb-block-read/jvp/parquet-compactor
branch
jesusvazquez
changed the title
francoposa
added a commit
that referenced
this pull request
Apr 15, 2025
…r clarity & testability (#11222) * move readTsdb to parquet storage sub-package; rename method & vars for clarity * add license header
jesusvazquez
pushed a commit
that referenced
this pull request
Apr 16, 2025
…r clarity & testability (#11222) * move readTsdb to parquet storage sub-package; rename method & vars for clarity * add license header
jesusvazquez
pushed a commit
that referenced
this pull request
Apr 16, 2025
…r clarity & testability (#11222) * move readTsdb to parquet storage sub-package; rename method & vars for clarity * add license header
jesusvazquez
pushed a commit
that referenced
this pull request
Apr 16, 2025
…r clarity & testability (#11222) * move readTsdb to parquet storage sub-package; rename method & vars for clarity * add license header
jesusvazquez
added a commit
that referenced
this pull request
Apr 16, 2025
* Parquet converter Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com> Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com> Co-authored-by: Franco Posa <franco.posa@grafana.com> * move readTsdb to parquet storage sub-package; rename method & vars for clarity & testability (#11222) * move readTsdb to parquet storage sub-package; rename method & vars for clarity * add license header * Parquet: Initialize parquet converter module (#11226) * Initialize parquet compactor module Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com> * Rename to parquet converter Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com> * Implement allowlist * fix reader tests * Update docs * also skip disallowed tenants when converting blocks * fix initialization of allowedTenants * various name changes --------- Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com> Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com> --------- Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com> Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com> Co-authored-by: Franco Posa <franco.posa@grafana.com> Co-authored-by: Franco Posa <franco@francoposa.io> Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to isolate & unit test this stuff and reading a TSDB block to parquet rows should be general enough that it does not need to be specific to the compactor.
Also updated
pkg/storage/parquetfiles to be the package namepkg/storage/parquetrather than justpkg/storage, to match other storage subpackages.What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.