Create Plugin: Introduce experimental Rspack feature flag #1564
+526
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
minor
jackw
force-pushed
the
jackw/feature-rspack
branch
3 times, most recently
from
636f597 to
184efa0
Compare
jackw
changed the title
jackw
moved this from 🧑💻 In development
to 🔬 In review
in Plugins Platform / Grafana Community
jackw
force-pushed
the
jackw/feature-rspack
branch
from
184efa0 to
ca0910a
Compare
jackw
force-pushed
the
jackw/feature-rspack
branch
2 times, most recently
from
ef04d48 to
6b529b0
Compare
…specific bundler configs
…nabled to update command
jackw
force-pushed
the
jackw/feature-rspack
branch
from
6b529b0 to
e8e9b29
Compare
andresmgot
approved these changes
Apr 25, 2025
| constructor(options = {}) { | ||
| this.options = Object.assign( | ||
| { | ||
| port: 35729, |
There was a problem hiding this comment.
should this be a random port?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Now Rspack has released 1.2.4 which includes the subresource integrity plugin - I think we can begin experimenting with using Rspack for bundling plugins.
Note that right now Rspack is missing the functionality to pass a regular expression to the clean feature prevent deletion of backend files in the dist directory.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@5.20.0-canary.1564.14643565723.0 # or yarn add @grafana/create-plugin@5.20.0-canary.1564.14643565723.0