Skip to content

python: Use private logger instead of root logger #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

vrslev
Copy link
Contributor

@vrslev vrslev commented Apr 18, 2025

The library currently uses the root logger, which can be problematic when you want to suppress these logs. This is particularly relevant for pyroscope.shutdown(). To address this, I have introduced the use of a private logger in pyroscope.shutdown(), and also in pyroscope.configure() for consistency.

The library currently uses the root logger, which can be problematic when you want to suppress these logs. This is particularly relevant for `pyroscope.shutdown()`. To address this, I have introduced the use of a private logger in `pyroscope.shutdown()`, and also in `pyroscope.configure()` for consistency.
@vrslev vrslev requested review from a team as code owners April 18, 2025 09:58
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vrslev
Copy link
Contributor Author

vrslev commented Apr 18, 2025

@grafana/pyroscope-rs

@korniltsev korniltsev merged commit f851881 into grafana:main Apr 18, 2025
26 checks passed
@korniltsev
Copy link
Collaborator

Thanks!

@vrslev vrslev deleted the py-unuse-root-logger branch April 18, 2025 10:38
@vrslev vrslev restored the py-unuse-root-logger branch April 18, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants