chore: Update prometheus to version v3 #4094
Open
+894
−586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcsanmi
approved these changes
Apr 10, 2025
Note this will relax the label validation and allow the newer metric selectors format to allow utf8 symbols.
Instead fully equality of the matcher object, which breaks with the latest prometheus version.
simonswine
force-pushed
the
20250410_update-prometheus-dependency
branch
from
ccc29b4 to
358ed4e
Compare
This change is a consequence by the grpc-go change in v1.70.0, which got merged here: grpc/grpc-go#7905 As we do call `WithDisableRetry()`, it should be a no-op.
simonswine
force-pushed
the
20250410_update-prometheus-dependency
branch
from
bed5aa8 to
0af7e31
Compare
simonswine
changed the title
simonswine
commented
Apr 16, 2025
Comment on lines
+130
to
154
| // The default gRPC service config is explicitly set to balance between | ||
| // instances. | ||
| const grpcServiceConfig = `{ | ||
| "methodConfig": [{ | ||
| "name": [{"service": ""}], | ||
| "retryPolicy": {} | ||
| }], | ||
| "healthCheckConfig": { | ||
| "serviceName": "pyroscope.segment-writer" | ||
| } | ||
| "methodConfig": [ | ||
| { | ||
| "name": [ | ||
| { | ||
| "service": "" | ||
| } | ||
| ], | ||
| "retryPolicy": { | ||
| "maxAttempts": 4, | ||
| "initialBackoff": "0.1s", | ||
| "maxBackoff": "1s", | ||
| "backoffMultiplier": 2, | ||
| "retryableStatusCodes": [ | ||
| "UNAVAILABLE" | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "healthCheckConfig": { | ||
| "serviceName": "pyroscope.segment-writer" | ||
| } | ||
| }` |
There was a problem hiding this comment.
@kolesnikovae please take a look at this, I think after grpc/grpc-go#7905 we cannot do this anymore using the service config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is change of behaviour as it will relax the label validation and allow the newer metric selectors format, which in turn needs to be used to use the full character set.
There is also some bigger impact to the remote write/metrics export, as there is a new version of remote write in prometheus v3: https://prometheus.io/docs/specs/prw/remote_write_spec_2_0/
This will be the new label selector format:
In order to override other validation at a later point, we also need to set:
I am not planning to do this as part of this PR.