fix(v2): segment upload timeout #4097
Merged
+36
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the segment upload timeout is applied to each individual attempt. In practice, I saw that a configuration with 3 attempts and 1s timeout may take up to 5 seconds, which is not desirable.
This change modifies the behavior so that the timeout covers the entire upload routine – including backoff intervals, delays, and other overhead – making the process more predictable.
If a single attempt takes too long (e.g., due to a slow connection), it may be recovered using a hedged request. Regular retries are intended to recover from transient errors.