-
Notifications
You must be signed in to change notification settings - Fork 20
Improve Pyroscope Profiling Integration #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve Pyroscope Profiling Integration #130
Conversation
@SeamusGrafana would you mind adapting this to |
Thanks @federicotdn Have done that and tested locally, I can see the But not all, mostly the newer ones; Have I missed it somewhere? Thanks |
I've changed the service name attribute for those endpoints, could you merge |
Yeah, using Will test shortly, thanks! |
Thanks @federicotdn I tried again but got the same results as before. |
Aah ok. Could you share what set of commands you are using locally to test this? I can try reproducing it locally. |
Thanks @federicotdn From the root of the branch;
Copy the SHA256 for the gernated image, and it add it into here;
Run Navigate to QP site in browser, genertae few pizzas, then test new I have an Alloy, Mimir, Loki, Tempo and Pyroscope already configured where QP sends data too. |
Hey @federicotdn, I managed to find and fix the issue with the I also bumped the Pyrocope Version too, and Merged You now see a Are you able to have a look at this and review it when you can please (not urgent). Thanks! |
Add Support for the Go Profiles GitHub Integration in Grafana Cloud.
Add Support for the Span Profiles to Traces Feature
Some Minor updates to
README.md
to fix some misc Lint Issues, and improve Docs.