Skip to content

fix(gar/gcs): stop creating files and folders within workdir #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(gar/gcs): stop creating files and folders within workdir #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01eac4f
Disable credentials file creation on google-github-actions/auth
guicaulada Apr 8, 2025
26b1366
Fix workdir drift caused by shared-workflows checkout
guicaulada Apr 8, 2025
855766d
Fix checkout path for shared-workflows
guicaulada Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions actions/login-to-gar/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ runs:
token_format: access_token
workload_identity_provider: "projects/304398677251/locations/global/workloadIdentityPools/github/providers/github-provider"
service_account: ${{ steps.construct-service-account.outputs.service_account }}
create_credentials_file: false
continue-on-error: true
- name: Service account deprecation warning
if: ${{ steps.auth_with_service_account.outputs.access_token != '' }}
Expand All @@ -52,6 +53,7 @@ runs:
with:
project_id: "grafanalabs-workload-identity"
workload_identity_provider: "projects/304398677251/locations/global/workloadIdentityPools/github/providers/github-provider"
create_credentials_file: false
- name: Login to GAR
if: ${{ steps.auth_with_service_account.outputs.access_token == '' }}
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
Expand Down
1 change: 1 addition & 0 deletions actions/login-to-gcs/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,4 @@ runs:
with:
workload_identity_provider: "projects/304398677251/locations/global/workloadIdentityPools/github/providers/github-provider"
service_account: ${{ steps.construct-account-vars.outputs.service_account }}
create_credentials_file: false
4 changes: 2 additions & 2 deletions actions/push-to-gar-docker/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ runs:
with:
repository: ${{ env.action_repo }}
ref: ${{ env.action_ref }}
path: shared-workflows
path: ../shared-workflows
persist-credentials: false

- name: Get repository name
Expand Down Expand Up @@ -138,7 +138,7 @@ runs:

- name: Login to GAR
if: ${{ inputs.push == 'true' }}
uses: ./shared-workflows/actions/login-to-gar
uses: ../shared-workflows/actions/login-to-gar
with:
environment: ${{ inputs.environment }}

Expand Down
4 changes: 2 additions & 2 deletions actions/push-to-gcs/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ runs:
with:
repository: ${{ env.action_repo }}
ref: ${{ env.action_ref }}
path: shared-workflows
path: ../shared-workflows
persist-credentials: false
- name: Resolve GCP project
id: resolve-project
Expand All @@ -70,7 +70,7 @@ runs:
echo "project=${PROJECT}" | tee -a ${GITHUB_OUTPUT}
- name: Login to GCS
id: login-to-gcs
uses: ./shared-workflows/actions/login-to-gcs
uses: ../shared-workflows/actions/login-to-gcs
with:
bucket: ${{ inputs.bucket }}
environment: ${{ inputs.environment }}
Expand Down
Loading