Skip to content

feat(push-to-gar-docker): add target input for multi-stage builds #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

feat(push-to-gar-docker): add target input for multi-stage builds #904

merged 2 commits into from
Apr 17, 2025

Conversation

ricky-undeadcoders
Copy link
Contributor

Expose the underlying target input from docker's build-push-action

@ricky-undeadcoders ricky-undeadcoders requested a review from a team as a code owner April 16, 2025 19:03
zerok
zerok approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@zerok zerok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiousity: Why can the original input be used by other actions? That value has to come from somewhere 🙂

@zerok
Copy link
Contributor

zerok commented Apr 17, 2025

Just out of curiousity: Why can the original input be used by other actions? That value has to come from somewhere 🙂

nvm, I'm stupid :)

@ricky-undeadcoders ricky-undeadcoders added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit fd2e2da Apr 17, 2025
8 checks passed
@ricky-undeadcoders ricky-undeadcoders deleted the rwhitaker/add-target-option-push-to-gar branch April 17, 2025 14:33
@github-actions github-actions bot mentioned this pull request Apr 17, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerok zerok zerok approved these changes

@dblinkhorn dblinkhorn dblinkhorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricky-undeadcoders @zerok @dblinkhorn