Skip to content

feat: add support for per check alerts #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025
Merged

Conversation

VikaCep
Copy link
Contributor

@VikaCep VikaCep commented Apr 11, 2025

Adds support for Per Check Alerts so that the terraform provider can consume it.

Ref https://github.com/grafana/synthetic-monitoring/issues/228
Required for grafana/terraform-provider-grafana#2128

@VikaCep VikaCep requested a review from ka3de April 14, 2025 15:14
@VikaCep VikaCep force-pushed the sm-alerts-per-check-support branch from 4bdad88 to 79eb150 Compare April 14, 2025 22:07
@VikaCep VikaCep changed the title fix: add support for per check alerts feat: add support for per check alerts Apr 14, 2025
Copy link

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM! Just made a small few comments and a consideration on the check alert type as the GET endpoint now includes its status.

Also, I see that from the Terraform provider PR we reference docs for the alerts API in this repo that do not exist (here).

@VikaCep VikaCep marked this pull request as ready for review April 22, 2025 20:38
@VikaCep VikaCep requested a review from a team as a code owner April 22, 2025 20:38
@VikaCep VikaCep requested review from d0ugal and ka3de April 22, 2025 20:38
Copy link

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VikaCep VikaCep merged commit e41e381 into main Apr 24, 2025
3 checks passed
@VikaCep VikaCep deleted the sm-alerts-per-check-support branch April 24, 2025 13:14
@sm-release-app sm-release-app bot mentioned this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants