Skip to content

Simplify the SubgraphRunner a little #5953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 21, 2025
Merged

Simplify the SubgraphRunner a little #5953

merged 9 commits into from
Apr 21, 2025

Conversation

lutter
Copy link
Collaborator

@lutter lutter commented Apr 18, 2025

There's lots more that could and should be done, but it's a start to make the runner more readable

@lutter lutter requested a review from mangas April 18, 2025 01:33
mangas
mangas approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@mangas mangas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely seems better than before, would be great to break into functions that can be tested, ideally that don't require self or side effects.

@lutter lutter merged commit 2f365c3 into master Apr 21, 2025
6 checks passed
@lutter lutter deleted the lutter/runner branch April 21, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangas mangas mangas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lutter @mangas