Phase end cutoff mitigation #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with potential overhead
* main: (68 commits) Guard clause that runner.run_until may never be used without a context Software add now accepts but logs unknown endpoints other than GitHub and GitLab Added volumes key allow_unsafe and skip_unsafe technically usable via configuration. Not exposed Bump psycopg[binary] from 3.2.8 to 3.2.9 (#1188) Bump redis from 5.2.1 to 6.1.0 (#1187) Added statistical significance schedule mode [skip ci] (#1186) Bump deepdiff from 8.4.2 to 8.5.0 (#1181) Bump pylint from 3.3.6 to 3.3.7 (#1175) Adding dev-no-sleeps and dev-no-optimization to the cluster (#1185) Shm size (#1184) Shutdown in the cluster happens now dynamically depending on what is configured in shutdown_on_job_no Memory resource limits may also be plain int or float\nWill then be interpreted as bytes Bump playwright/python in /docker/auxiliary-containers/gcb_playwright (#1174) Bump psycopg[binary] from 3.2.7 to 3.2.8 (#1183) Bump hiredis from 3.1.0 to 3.1.1 (#1182) Temperature errors are reset now inline (fix): Version is allowed to be int, float or datetime too Added --dev-no-save flag (#1179) Removed duplicate ln ...
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
ArneTR
added a commit
that referenced
this pull request
May 18, 2025
* main: (22 commits) Hotfix: Compare values were 3 orders of magnitude to low due to double division (#1191) Sampling rate rework (#1194) Phase padding can now be turned on and off (#1193) User 0 should have flow_process_duration and total duration only at 30 minutes and no data in json 'measurement' AI-Tests can now activated and deactivated in tests (Testing QoL): JS errors in frontend tests are now reported typo added no-else-raise Checking in more cases now if github detected even if path broken AI Optimisations Frontend added to FOSS version as appetizer (#1192) Allow repo URLs with unknown schemes but issues warning Revert "Test fix\nwe changed from failing on unknowns to allowing them due to allowing other vendors or private repos with reduced capbility tokens that might be cloneable but do not expose the API" general wording Runtime phase reconstruction only when runtime phase is present (fix): shutdown_on_job_no must only be non false (fix): Null check for resolution must also be in system_checks (fix): Providers without resolution must also be mappable to _sampling_interval_padding Test fix\nwe changed from failing on unknowns to allowing them due to allowing other vendors or private repos with reduced capbility tokens that might be cloneable but do not expose the API Phase end cutoff mitigation (#1161) Guard clause that runner.run_until may never be used without a context ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a mitigation method for measurement cut-offs.
This is particular helpful if your sampling resolution is prone to undersampling.
We have seen issues for instance in:
The mechanic implemented does the following:
Greptile Summary
This PR addresses measurement cut-off issues by implementing phase timing adjustments and runtime phase reconstruction. Key changes include:
_sampling_interval_paddinginscenario_runner.pyto store slowest provider's resolution and extend phase windowsreconstruct_runtime_phase()inphase_stats.pyto rebuild runtime statistics by aggregating sub-phase datacheck_largest_sampling_rate()insystem_checks.pyto warn when providers exceed 1000ms sampling rate