-
Notifications
You must be signed in to change notification settings - Fork 45
Adding a new tutorial (Advection-Deffusion Equation) #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @amartinhuertas @AlexandreMagueresse |
Hi @yiyuef I will be having a look. Sorry for the delay, for some reason I did not get notifications from this. |
deps/build.jl
Outdated
@@ -5,6 +5,7 @@ repo_src = joinpath(@__DIR__,"..","src") | |||
notebooks_dir = joinpath(@__DIR__,"..","notebooks") | |||
|
|||
files = [ | |||
"Gmsh/Gridap workflow"=>"gmsh_gridap.jl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you changed the name at some point. I would set it to
"Advection-diffusion" => "advection_diffusion.jl"
Also, it should definitely not be the first tutorial. I would place it between stokes and the isotropic damage model, if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah you are correct. I forgot to change the name in build.jl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think put it after stokes is good!
Also, you should pull from |
Sorry what do you mean by "pull from |
I have done some updates to the git pull origin master from your local copy of this branch, then push the changes into the PR. |
@JordiManyer I think I have updated the PR. |
deps/build.jl
Outdated
@@ -14,6 +14,7 @@ files = [ | |||
"Darcy equation (with RT)"=>"darcy.jl", | |||
"Incompressible Navier-Stokes"=>"inc_navier_stokes.jl", | |||
"Stokes equation" => "stokes.jl", | |||
"Advection-diffusion" => "advection_diffusion.jl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a coma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake! done.
Hi,
I just created a new tutorial that aims to help beginners getting used to the workflow from creating models in Gmsh to solving the PDE in the FE space in Gridap.
I hope it would make things easier for those who just started learning PDEs and want to take a glance at the real application.
Thanks!