Skip to content

Adding a new tutorial (Advection-Deffusion Equation) #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 5, 2025

Conversation

yiyuef
Copy link
Contributor

@yiyuef yiyuef commented Dec 7, 2024

Hi,

I just created a new tutorial that aims to help beginners getting used to the workflow from creating models in Gmsh to solving the PDE in the FE space in Gridap.

I hope it would make things easier for those who just started learning PDEs and want to take a glance at the real application.

Thanks!

@yiyuef yiyuef changed the title Adding a new tutorial (Laplace Equation) Adding a new tutorial (Advection-Deffusion Equation) Dec 15, 2024
@yiyuef
Copy link
Contributor Author

yiyuef commented Dec 16, 2024

Hi, @amartinhuertas @AlexandreMagueresse
I am wondering if the new tutorial is appropriate for the package? Thanks!

@JordiManyer
Copy link
Member

Hi @yiyuef I will be having a look. Sorry for the delay, for some reason I did not get notifications from this.

@JordiManyer JordiManyer self-requested a review March 4, 2025 22:12
deps/build.jl Outdated
@@ -5,6 +5,7 @@ repo_src = joinpath(@__DIR__,"..","src")
notebooks_dir = joinpath(@__DIR__,"..","notebooks")

files = [
"Gmsh/Gridap workflow"=>"gmsh_gridap.jl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you changed the name at some point. I would set it to

"Advection-diffusion" => "advection_diffusion.jl"

Also, it should definitely not be the first tutorial. I would place it between stokes and the isotropic damage model, if you want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah you are correct. I forgot to change the name in build.jl.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think put it after stokes is good!

@JordiManyer
Copy link
Member

Also, you should pull from master, I've been doing some upkeep.

@yiyuef
Copy link
Contributor Author

yiyuef commented Mar 4, 2025

Sorry what do you mean by "pull from master"?

@JordiManyer
Copy link
Member

JordiManyer commented Mar 4, 2025

Sorry what do you mean by "pull from master"?

I have done some updates to the master branch of this repo. You do not have these changes in your branch. Could you please pull the changes into your branch, i.e by doing

git pull origin master

from your local copy of this branch, then push the changes into the PR.

@yiyuef
Copy link
Contributor Author

yiyuef commented Mar 5, 2025

@JordiManyer I think I have updated the PR.

deps/build.jl Outdated
@@ -14,6 +14,7 @@ files = [
"Darcy equation (with RT)"=>"darcy.jl",
"Incompressible Navier-Stokes"=>"inc_navier_stokes.jl",
"Stokes equation" => "stokes.jl",
"Advection-diffusion" => "advection_diffusion.jl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a coma

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my mistake! done.

@JordiManyer JordiManyer merged commit 5d90b68 into gridap:master Mar 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants