Skip to content

xds: Enable least request by default #12054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
+2 −2
Merged

xds: Enable least request by default #12054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc01a30
xds: Enable least request by default
ejona86 May 7, 2025
f2c7f32
Remove assertion that least request is disabled
ejona86 May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xds/src/main/java/io/grpc/xds/XdsClusterResource.java
View file
Original file line number Diff line number Diff line change
@@ -60,7 +60,8 @@ class XdsClusterResource extends XdsResourceType<CdsUpdate> {
static boolean enableLeastRequest =
!Strings.isNullOrEmpty(System.getenv("GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST"))
? Boolean.parseBoolean(System.getenv("GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST"))
: Boolean.parseBoolean(System.getProperty("io.grpc.xds.experimentalEnableLeastRequest"));
: Boolean.parseBoolean(
System.getProperty("io.grpc.xds.experimentalEnableLeastRequest", "true"));
@VisibleForTesting
public static boolean enableSystemRootCerts =
GrpcUtil.getFlag("GRPC_EXPERIMENTAL_XDS_SYSTEM_ROOT_CERTS", false);
1 change: 0 additions & 1 deletion xds/src/test/java/io/grpc/xds/GrpcXdsClientImplDataTest.java
View file
Original file line number Diff line number Diff line change
@@ -186,7 +186,6 @@ public void setUp() {
originalEnableRouteLookup = XdsRouteConfigureResource.enableRouteLookup;
originalEnableLeastRequest = XdsClusterResource.enableLeastRequest;
originalEnableUseSystemRootCerts = XdsClusterResource.enableSystemRootCerts;
assertThat(originalEnableLeastRequest).isFalse();
}

@After