-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix unified diff hunk header highlight to allow for single-number case #4228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+52
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
Mar 19, 2025
Hi @joshgoebel, can you please take another look and approve if this is ready? Thanks! |
Yang062
approved these changes
Apr 7, 2025
Yang062
approved these changes
Apr 7, 2025
joshgoebel
approved these changes
Apr 23, 2025
Build Size ReportChanges to minified artifacts in 6 files changedTotal change +7 B View Changes
|
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +4 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +24 B View Changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4227
Changes
Update the regex for matching a unified hunk header to allow for single numbers as well as comma-paired numbers.
From https://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html, emphasis mine:
Checklist
CHANGES.md