Skip to content

fix: insert last msg id in correct format #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zone117x
Copy link
Member

The last_msg_id expects an integer, but it was trying to insert the msg id format received from redis e.g. <msgId>-0.

Copy link

Vercel deployment URL: https://signer-metrics-czkznqexl-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pg/ingestion/pg-write-store.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@CharlieC3
Copy link
Member

Commenting here what I said in a DM:

once the signer metrics api catches up to its recorded block_height, it then starts writing to the last_redis_msg_id correctly. So if it’s just syncing blocks it already has in its DB, then the last_redis_msg_id does not update. That feels more like missing logic rather than a DB write error :thinking_face:

Are you sure this PR addresses the bug affecting the scenario described above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants