Skip to content

Make all the regression tests pass on CI #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

jarzec
Copy link
Contributor

@jarzec jarzec commented May 14, 2025

Make all the regression tests pass on CI:

  • Update Clang 18 to 19 for the regression tests to avoid failures due to bugs in Clang 18.
  • Fix failures of pure Cpp2 regression tests on Windows GitHub runners.
    • The tests fail due to:
      cpp2util.h(564): error C2065: 'EXIT_FAILURE': undeclared identifier`.
      
    • #include <cstdlib> for the same tests leads to errors of the kind:
      C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt\corecrt_math.h(444): error C2995: 'bool isfinite(_Ty) noexcept': function template has already been defined
      C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt\corecrt_math.h(444): note: see declaration of 'isfinite'
      C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt\corecrt_math.h(450): error C2995: 'bool isinf(_Ty) noexcept': function template has already been defined
      C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt\corecrt_math.h(450): note: see declaration of 'isinf'
      ...
      
    • The temporary solution to allow all tests to pass on CI before a better approach is found is simply:
      #ifndef EXIT_FAILURE
          #define EXIT_FAILURE 1
      #endif
      
  • Update regression tests data accordingly:
    • Update line numbers within cpp2util.h for compilation failure messages.
    • Remove error message files for test that started to pass with Clang 19.
    • Add binary execution output files for the tests that started to pass.

@hsutter
Copy link
Owner

hsutter commented May 14, 2025

Thanks, including for the EXIT_FAILURE catch!

@hsutter hsutter merged commit 5aa32ae into hsutter:main May 14, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants