Skip to content

Try dealing with the backwards incompatible changes in setuptools again #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2016

Conversation

gsnedders
Copy link
Member

This tries to address #231 again, reverting to platform_python_implementation. This should work everywhere with setuptools 18.5 above; see #231 for more discussion of this.

@codecov-io
Copy link

codecov-io commented Jun 6, 2016

Current coverage is 90.48%

Merging #263 into master will decrease coverage by 0.30%

@@             master       #263   diff @@
==========================================
  Files            51         51          
  Lines          6857       6840    -17   
  Methods           0          0          
  Messages          0          0          
  Branches       1317       1291    -26   
==========================================
- Hits           6225       6189    -36   
- Misses          472        485    +13   
- Partials        160        166     +6   

Powered by Codecov. Last updated by 5197f55...192a058

@gsnedders gsnedders modified the milestone: 0.99999999 Jun 6, 2016
@gsnedders
Copy link
Member Author

Hmm, maybe shouldn't run with loads of setuptools versions…

@gsnedders gsnedders force-pushed the fix_setuptools_fun branch from bf37228 to 1fab9fd Compare June 6, 2016 21:00
@gsnedders gsnedders force-pushed the fix_setuptools_fun branch from 1fab9fd to c562f28 Compare June 6, 2016 21:51
@gsnedders gsnedders merged commit fbce67d into html5lib:master Jun 6, 2016
@gsnedders gsnedders deleted the fix_setuptools_fun branch June 6, 2016 22:00
@jraby
Copy link

jraby commented Jul 18, 2016

For the record, checking version of setuptools in the body of setup.py in this manner makes it impossible to install/upgrade setuptools at the same time as html5lib.

For example this fails:

cat >req.txt <<EOF
setuptools>=18.5
html5lib
EOF

virtualenv testenv
testenv/bin/pip install -r req.txt

Collecting setuptools>=18.5 (from -r req.txt (line 1))
  Using cached setuptools-24.0.3-py2.py3-none-any.whl
Collecting html5lib (from -r req.txt (line 2))
  Using cached html5lib-0.999999999.tar.gz
    Complete output from command python setup.py egg_info:
    html5lib requires setuptools version 18.5 or above; please upgrade before installing (you have 18.2)

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/49/p3xmv77x6fnb2lwl5kpvmvs40000gp/T/pip-build-0vYISn/html5lib
You are using pip version 7.1.2, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

@gsnedders
Copy link
Member Author

@jraby can you file a new issue for that? that's a good point, and should check if removing that if makes it work (I assume it does!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants