fix: pass arguments to server.close #635
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure that your pull request fulfills these requirements:
master
branchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
Rather bug fix.
What changes did you make?
As for
server.listen
,server.close
(both for HTTP and HTTPS servers, as returned by union) takes an optional callback which is called on completion or error. This patch adds argument forwarding forclose
.Provide some example code that this change will affect, if applicable:
Is there anything you'd like reviewers to focus on?
Well there's no tests, should I somehow write one?
As a side note,
HttpServer.prototype.close
forwards the return value ofthis.server.close
, i.e.this
. ButHttpServer.prototype.listen
does not. I think it should too.Please provide testing instructions, if applicable:
Above code.