feat: Allow to add webhooks from Create Alert modal

[ernestii]

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5a3b5a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hyperdx-v2-oss-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2025 4:33pm

[Copilot]

Pull Request Overview

This PR adds the ability to create and add webhooks directly from the Create Alert modal. The key changes include:

• Integrating a modal in Alerts.tsx to host the CreateWebhookForm.
• Refetching the list of webhooks upon successful webhook creation and updating the form field.
• Exporting and updating the CreateWebhookForm component in TeamPage.tsx, including a change in its onSuccess signature to receive a webhook ID.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
packages/app/src/components/Alerts.tsx	Adds modal logic and uses a new webhook creation form to update webhook state.
packages/app/src/TeamPage.tsx	Exports and adjusts CreateWebhookForm to pass the generated webhook ID on success.

[Copilot]

Potential issue: If response.data is undefined, onSuccess will be called with undefined. Consider adding an explicit null check or a fallback to ensure that a valid webhook ID is passed.

Suggested change

	onSuccess(response.data?._id);
	if (response.data && response.data._id) {
	onSuccess(response.data._id);
	} else {
	console.warn('Webhook creation succeeded, but no ID was returned.');
	notifications.show({
	color: 'yellow',
	message: 'Webhook created, but no ID was returned by the server.',
	});
	}

[teeohhem]

@ernestii what happens when response.data is empty in the upstream onSuccess event? Depending on that, this may be a valid suggestion (except for the notification).

[ernestii]

technically api should never return 200 with empty data, it'll return 500 after catching the error

      await webhook.save();
      res.json({
        data: webhook,
      });
    } catch (err) {
      next(err);
    }

onSuccess ultimately is used for selecting the newly created webhook in the dropdown, so I made the webhookId optional upstream