Skip to content

feat: Open span details panle in Service Health dashboard #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ernestii
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: be6d387

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdx-v2-oss-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 2:54am

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to open a span details panel within the Service Health dashboard. The main changes include:

  • Adding state and callbacks for managing the side panel display.
  • Integrating a new side panel component (DBRowSidePanel) along with updates to the SQL row table component to support row expansion.
  • Utilizing new hooks (useQueryState, useSource) to manage and retrieve the necessary data for the side panel.
Comments suppressed due to low confidence (1)

packages/app/src/components/ServiceDashboardSlowestEventsTile.tsx:44

  • [nitpick] The parameter name 'rowWhere' may be unclear given its use. Consider renaming it to 'rowId' or 'selectedRowId' for improved clarity.
const handleRowExpandClick = useCallback(

@kodiakhq kodiakhq bot merged commit 94aa5f8 into v2 Apr 30, 2025
6 checks passed
@kodiakhq kodiakhq bot deleted the ernest/hdx-1223-when-clicking-on-spans-it-should-open-span-details-panel branch April 30, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants