-
Notifications
You must be signed in to change notification settings - Fork 249
feat: Allow to sort logs by timestamp in ASC direction #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Allow to sort logs by timestamp in ASC direction #787
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables sorting logs by timestamp in ascending order by introducing an order state and a toggle mechanism in the log table header.
- Added order and setOrder props in RawLogTable and updated prop types
- Updated the timestamp header to support toggling sort order (while ensuring live mode always remains in descending order)
- Propagated the order property to affect caching (resultsKey) and child components
Files not reviewed (1)
- packages/app/styles/LogTable.module.scss: Language not supported
? 'Time' | ||
: `Timestamp${isUTC ? ' (UTC)' : ' (Local)'}`, | ||
header: () => ( | ||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding role="button" and keyboard event support (e.g., onKeyDown) to the clickable header div for improved accessibility.
<div | |
<div | |
role="button" | |
tabIndex={0} |
Copilot uses AI. Check for mistakes.
4ec13e3
to
8b030f4
Compare
8b030f4
to
9828308
Compare
Allow to sort logs by timestamp in ASC direction.
Screen.Recording.2025-05-01.at.8.10.04.PM.mov