Skip to content

dominant color processing on a full image + Fixes #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented Apr 18, 2025

…d to all LEDs (#1853)

Summary

  • Support for dominant color processing on a full image which is applied to all LEDs (Dominant Color all Leds #1853)
  • Ensure that API service does not process commands when Hyperion is quitting
  • Provide additional details in error dialogue
  • Fix: Update UI that Single and Multiple instance commands are correctly supported
  • Fix: Ensure UI getConfig always get instances
  • Fix: Effects are not longer created/deleted per instance
  • Fix: Return correct mapping type for a running instance
  • Fix: Correct instance dependencies on API commands
  • Fix: Flatbuffer Processing

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

image

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
fixes #1853

@Lord-Grey Lord-Grey self-assigned this Apr 18, 2025
@Lord-Grey Lord-Grey added this to Core Apr 18, 2025
@Lord-Grey Lord-Grey moved this to In Progress in Core Apr 18, 2025
@Marxon
Copy link

Marxon commented Apr 20, 2025

Noticed two issues:

  1. selecting the new modes fom hyperions remote tab results with "invalid params" errror
  2. translations are missing
    -german on picture processing tab:
    Dominante Farbe Gesamtbild - auf alle LED angewandt
    Dominante Farbe Gesamtbild fortgeschritten - auf alle LED angewandt
    -german on remote tab:
    Dominante Farbe Gesamtbild
    Dominante Farbe Gesamtbild fortgeschritten

@Lord-Grey
Copy link
Collaborator Author

Lord-Grey commented Apr 20, 2025

@Marxon Thanks for sharing your findings.

on 1. I will have a look after the Easter break
on 2. We make use of PoEditor to allow the community to help with translations. Therefore, even the German texts will be translated after merging the PR and will come later :)

@Lord-Grey
Copy link
Collaborator Author

Lord-Grey commented Apr 21, 2025

  1. selecting the new modes fom hyperions remote tab results with "invalid params" errror

I missed to have the new dominant color feature registered for the API :(
With the latest update, the buttons should work as expected.

Unfortunately, the updates are currently applied to all instances running and not to the current one on screen and the English button texts are missing too.
I will have a look on those issues later.

For now you can continue testing :)

@Lord-Grey Lord-Grey changed the title Support for dominant color processing on a full image which is applie… dominant color processing on a full image + Fixes Apr 22, 2025
@Lord-Grey
Copy link
Collaborator Author

@Marxon I did multiple updates and fixes. Would you mind testing again?
German translations are not yet there, but the English texts should be.

@Marxon
Copy link

Marxon commented Apr 23, 2025

Hi again,
hope you had an joyful easter break!
Issue 1: selecting the new modes fom hyperions remote tab results with "invalid params" errror
Fixed!
Glad to could contribute in some way. :)
Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Dominant Color all Leds
2 participants