Planar layouts and images #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to Box and its inner unique in the standard library, this should allow better sharing of implementations between buffer types where otherwise we would leak the rather private traits that contain the shared behaviour. And we only want that trait to make sense for our own selection of buffers since the exposed image containers are all concrete buffers.
The largest use of that deref is the methods available on slices and on `&buf` such as aligned operations and lengths. These can be provided in a much more generic way even for underlying representations that are not that specific (`Freeze`) buffer type but also for !Sync byte buffers and atomic buffers. We just need to contract the composed operations for modifying such buffers so that the signatures only mention the Self type of them respectively. These additional methods will be added to `BufferLike` in time.
HeroicKatora
force-pushed
the
2025-plane-layouts
branch
from
f2dcbed to
f2ea788
Compare
This documents it and aligns the return type to the standard library (unstable) `slice::get_many` interface where errors are returned as errors and only a full success works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.