Skip to content

feat: add LocalOrAws #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

feat: add LocalOrAws #23

merged 1 commit into from
May 14, 2025

Conversation

anna-carroll
Copy link
Contributor

@anna-carroll anna-carroll commented May 12, 2025

Add signer which accepts local private key signer or AWS signer

@anna-carroll anna-carroll self-assigned this May 12, 2025
@anna-carroll
Copy link
Contributor Author

should I impl FromEnv for LocalOrAws?

@prestwich
Copy link
Member

FromEnvVar

Copy link
Member

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prestwich
Copy link
Member

need to gate signers with the alloy feature

Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just need to either fix or remove the doctest

@prestwich prestwich enabled auto-merge (squash) May 14, 2025 19:31
@prestwich prestwich merged commit 70a863b into main May 14, 2025
6 checks passed
@anna-carroll anna-carroll deleted the anna/signer branch May 16, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants