fix: Fix the broken test_valid_requirements test
#3673
Conversation
There was a problem hiding this comment.
The multiple result issue is going to need some additional fixes, probably using PURL since for common words like 'requests' the results may just be plain wrong. But I think you've got the right approach for dealing with this right now. Thank you!
I'm going to commit a suggestion for a slightly clearer error message and I may cause a merge conflict because of the test disabling PR that just got merged, so expect a bit of churn in this PR while I get that sorted.
|
Updating the branch to see where we're at. Sorry this fell off my radar! |
|
I'm trying to update the branch to see what's going on with this again, but it looks like it's pulling in a bunch of changes I don't want so it may need bigger fixes that I can do through the web interface. |
|
Okay, this is not working (as in, the test is still failing) and it looks like a couple of the generated fuzz files somehow are stuck in this pull request. I'm going to go ahead and close this, but feel free to make a fresh branch with only your test_valid_requirements changes and open it up again if you can get the test to actually work. |
fixes #3644 .
The test "test_valid_requirements" in test/test_package_list_parser.py is broken. This PR attempts to fix it.
For more context on why this test is failing and why I have taken this approach to fix this, please refer to my post here on gitter.