Allow (and use by default) ORIGIN-relative driver paths #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone have any opinions on this? |
|
Ping; can anyone take a look at this? |
|
not familiar with this part, @xhaihao could you help to review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaves similarly to the
$ORIGINfeature in theRPATHandRUNPATHELF headers. It allows libva and the driver modules to be directory-portable (without having to set the env var at runtime), since libva only needs the path to the library dir relative to its own install dir, rather than an absolute path.This retains compatibility with existing drivers' build systems by setting the pkgconfig driverdir value, as with the existing code.
As far as I can tell,
dladdris available on all targeted systems.I was initially concerned that using
dladdrthis way might cause problems for static linking, but that's not supported in libva anyway.