fix: e2e modular deprecation fixes + auth MFA modular fixes #8499
+1,329
−508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
If #8498 is merged before this I can rebase this on to it, then add a final coup-de-grace commit that turns on strict mode in the e2e suite |
MichaelVerdon
approved these changes
Apr 29, 2025
otherwise it delegates to a method that warns of deprecation, because it was deprecated in namespace API, however for modular API `multiFactor` with specific parameters is the way to create a MultiFactorUser
this one had lots of API usage restructurings to match the JS reference / MFA guides
mechanical fixes grouped together for all the smaller-line-count packages
mikehardy
force-pushed
the
@mikehardy/e2e-deprecation
branch
from
518257d to
c8ddb5c
Compare
|
Android test was flaky and after ruminating I know why:
Ideally the flaky tests are fixed. But at minimum the strict mode + retries settings should be dis-entangled. I only did that to speed up discovery of e2e strict mode failures since retries made that very slow otherwise |
remove the entanglement with retries at same time - now that strict mode is on all the time and we are not actively finding new namespaced-API usage, we don't need to disable retries for strict mode as it should be more rare / less need for speed
mikehardy
force-pushed
the
@mikehardy/e2e-deprecation
branch
from
c8ddb5c to
db8b411
Compare
|
re-pushed with disentanglement of "strict mode" + "retry count" - left flaky tests for some other day |
mikehardy
added
Workflow: Pending Merge
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a huge package of commits aimed at cleaning up the entire e2e suite so there are no more deprecation warnings and it passes the suite in deprecation strict mode
With this and #8498 merged, the e2e suite looks modular-clean for the non-v8/namespaced tests
Related issues
This PR is also needed to get rid of messaging deprecations:
This docs PR prompted me to do this, since the auth API surface area had a gap for modular (
multiFactor) and I wanted to verify my direction to @DoctorJohn that the direct imports I was prescribing actually existed:Release Summary
All commits are conventional and ready for semantic release
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
The whole thing is prompted by testing and backed by testing - including all of the functionality changes
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter