Skip to content

LAG: Accept user specified lag.ifindex, also when listed in descending order #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented May 7, 2025

Fixes #2246

Tested: ./device-module-test -d eos -p clab lag

@ipspace
Copy link
Owner

ipspace commented May 8, 2025

This one looks a bit fishy. Have to check what happens if you have three LAGs and you number then "2, 1, none".

Will merge after 2.0.0 goes out.

@jbemmel
Copy link
Collaborator Author

jbemmel commented May 8, 2025

This one looks a bit fishy. Have to check what happens if you have three LAGs and you number then "2, 1, none".

That would assign overlapping ifindex values. The code is not currently trying to be overly sophisticated about auto-assigning missing ifindex values - it would mean keeping track of a set per node. Could be added

We could also change it such that the user has to specify all ifindex values if they decide to do one. I manually assign values to model what's configured, but in general I'd expect most users to leave them auto-assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] lag.ifindex ignored when descending order is used
2 participants