-
Notifications
You must be signed in to change notification settings - Fork 11
Now opens editor and viewer #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ddaec59
to
bc0aa13
Compare
Resolves #64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Let's make this better and open them in a split view, the editor on the left and the viewer on the right side. You can pass a options
argument. For reference:
* Fixed Color Picker issue * Fix lint check
I added the split panel feature using the "options" mode "split-left" when creating the widgets and the mode "tab-after" when creating new widgets after the split has already been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
The splitting seems to be working well. There is only one case (scenario 1) where it does not behave as expected.
Scenario 1
- User opens a file and closes the Editor tab
- User opens a second URDF file
- Issue: the split does not happen anymore and all the tabs open together
Scenario 2
- User opens a file and closes the Viewer tab
- User opens a second URDF file
- No issues: editor and viewer are split as expected
Made the split panel feature work in both scenarios by adding a few more functions to check for special cases and try to improve the tracking of the tabs (which still isn't perfect). A major shortcoming of this version is that sometimes (after certain scenarios like opening multiple tabs and keeping only the editors for some open and the viewers for others open) on refresh you get a third split panel. |
Made the urdf view open with the editor when:
-Creating a new urdf file.
-Opening an existing urdf file (by double-clicking on one from the file browser for example). Also improved the readability of the function that handles this by making it asynchronous.