Fixes #39 Scene lighting needs improvement #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
IsabelParedes
added
bug
IsabelParedes
requested changes
May 13, 2025
| angleStep | ||
| ) | ||
| }, | ||
| target: { |
There was a problem hiding this comment.
99% of the time, the robot will be at the origin, so we can probably remove these
|
|
||
| // Hemisphere light controls | ||
| this.controls.lights.hemisphere = { | ||
| skyColor: hemisphereFolder.addColor(hemisphereSettings, 'SkyColor'), |
There was a problem hiding this comment.
For the text displayed in the GUI, make the labels separate words
Sky Color
| @@ -51,6 +53,9 @@ export class URDFControls extends GUI { | |||
|
|
|||
| this._jointsFolder = this.addFolder('Joints'); | |||
| this._jointsFolder.domElement.setAttribute('class', 'dg joints-folder'); | |||
|
|
|||
| this._lightsFolder = this.addFolder('Lights'); | |||
There was a problem hiding this comment.
Since there exists a Scene folder already that affects some of the lights, it makes more sense to add the new folders to Scene instead of creating a new Lights folder.
There was a problem hiding this comment.
Also, since Joints is the main priority and now that the gui is getting longer, the folders should be reorganized in this order.
- Joints
- Workspace
- Scene
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Lights folder to give the user the option to manually control the lighting parameters for the three different light sources (Directional, Ambient and Hemispherical) as well as to visualize them using helpers.
For this, there was a need to modify the base CSS class to accommodate the new folder and add make the control panel scrollable and its close button visible.
This way, the user can adjust the lighting settings to their needs depending on the model being viewed.
I also tweaked the initial settings for the lighting to give the models a more "realistic" feel with better contrast and shadows.
For models that are completely white (like the Panda model), changing the background color of the scene (as lighting will have a much less important effect here) is a good solution that improves the contrast and visibility of the object.