Skip to content

text-block.renderer: open link in new tab #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

phips28
Copy link

@phips28 phips28 commented Dec 30, 2023

usually links in blog posts should open in a new tab.

we could also add a config maybe?

or we could check it the link is going to the same domain? => to not add _blank

Copy link

changeset-bot bot commented Dec 30, 2023

⚠️ No Changeset found

Latest commit: 96049bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 30, 2023

@phips28 is attempting to deploy a commit to the KMP Agency Team on Vercel.

A member of the Team first needs to authorize it.

@phips28 phips28 changed the title text-block.renderer.ts: open link in new tab text-block.renderer: open link in new tab Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant