chore: upgrade golangci-lint to 2.1.6 #1657
Conversation
Signed-off-by: Jayapriya Pai <janantha@redhat.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: slashpai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-triage
|
This issue is currently awaiting triage. If metrics-server contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ |
There was a problem hiding this comment.
This file was updated running the command golangci-lint migrate as mentioned in https://golangci-lint.run/product/migration-guide/
| config.Client.TLSClientConfig.Insecure = true | ||
| config.Client.TLSClientConfig.CAData = nil | ||
| config.Client.TLSClientConfig.CAFile = "" | ||
| config.Client.TLSClientConfig.Insecure = true //nolint:staticcheck |
There was a problem hiding this comment.
//nolint was added for the lint issue QF1008: could remove embedded field "TLSClientConfig" from selector (staticcheck).
I believe we need this current code instead of linter recommendation.
What this PR does / why we need it:
Upgrade golangci-lint to 2.1.16
https://golangci-lint.run/product/migration-guide
I believe this could fix the verify test that gets hang currently
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #