-
Notifications
You must be signed in to change notification settings - Fork 161
feat: Add runner observer architecture #4366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a runner observer architecture and updates the relevant modules to support the new design while resolving outdated imports. Key changes include:
- Updating the PurgeImagesReq import paths in agent-related modules from dto.manager.rpc_request to dto.agent.rpc_request.
- Adding new abstract backend types and kernel abstractions to support the runner observer design.
- Introducing BUILD files for new backends (docker, dummy, kubernetes) and updating dependency lists.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/ai/backend/agent/docker/agent.py | Updates the PurgeImagesReq import to use the agent RPC request module. |
src/ai/backend/agent/backends/types.py | Introduces abstract backend types for supporting multiple backend architectures. |
src/ai/backend/agent/backends/kernel.py | Adds new kernel abstractions and expands functionality for kernel creation and management. |
src/ai/backend/agent/backends/image_registry.py | Provides an abstract interface for agent image registry interactions. |
src/ai/backend/agent/backends/[kubernetes,dummy,docker] | Adds BUILD files for newly supported backends. |
src/ai/backend/agent/agent.py | Updates the PurgeImagesReq import to use the agent RPC request module. |
src/ai/backend/agent/BUILD | Updates dependency configurations to include new runner and observer modules. |
Comments suppressed due to low confidence (2)
src/ai/backend/agent/docker/agent.py:54
- The import for PurgeImagesReq has been updated to reference dto.agent.rpc_request instead of dto.manager.rpc_request; please ensure that all dependent modules and usage contexts are adjusted accordingly.
from ai.backend.common.dto.agent.rpc_request import PurgeImagesReq
src/ai/backend/agent/agent.py:80
- The updated import for PurgeImagesReq in this file now points to dto.agent.rpc_request; verify that this change is consistently propagated to all related components to avoid integration issues.
from ai.backend.common.dto.agent.rpc_request import PurgeImagesReq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
resolves #NNN (BA-MMM)
Checklist: (if applicable)
ai.backend.test
docs
directory