Remove dead code from ApplicationBuilder #55439
Closed
+0
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking for a way to add an additional routing configuration in
bootstrap/app.php
using named arguments in thewithRouting()
syntax. Seems like there's a$then
parameter that supports a callback to be executed after default configurations. Great.However I also noticed there's a property
$additionalRoutingCallbacks
defined and being iterated, but I don't see any possible way to actually populate that property.Because
$then
already achieves the very same, this might be dead code.Or if the existence of
$additionalRoutingCallbacks
is still applicable, then you might want to review how it can be set.This is just a heads-up PR.