Skip to content

Remove dead code from ApplicationBuilder #55439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Propaganistas
Copy link
Contributor

I was looking for a way to add an additional routing configuration in bootstrap/app.php using named arguments in the withRouting() syntax. Seems like there's a $then parameter that supports a callback to be executed after default configurations. Great.

However I also noticed there's a property $additionalRoutingCallbacks defined and being iterated, but I don't see any possible way to actually populate that property.

Because $then already achieves the very same, this might be dead code.
Or if the existence of $additionalRoutingCallbacks is still applicable, then you might want to review how it can be set.

This is just a heads-up PR.

@moory-se
Copy link

This can be used in inherited classes. It's useful, but mainly would be a (very) breaking change.

@AndrewMast
Copy link
Contributor

AndrewMast commented Apr 16, 2025

While it could potentially be a breaking change (and thus should probably be targeted to master), I have not been able to find any instances where $additionalRoutingCallbacks is used. Nothing shows up in a search engine or in a quick GitHub search.

Even in Taylor's Laracon 2024 PR that added the $additionalRoutingCallbacks property, I could find no other references besides the ones that are being removed in this PR.

@taylorotwell
Copy link
Member

Going to just leave it for now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants