Skip to content

Update publishing to new gradle plugin #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Update publishing to new gradle plugin #39

wants to merge 11 commits into from

Conversation

Berstanio
Copy link

The 'maven' publishing plugin is deprecated since gradle 5 and was removed in newer versions:
https://docs.gradle.org/current/userguide/upgrading_version_5.html
This pr upgrades the publishing process to use the new 'maven-publish' plugin.

Due to some generic issues I encountered when testing locally, I upgraded gradle in the same run to 7.3.3 which resolved them.

SimonIT
SimonIT suggested changes Nov 2, 2024
View reviewed changes
Copy link
Member

@SimonIT SimonIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm overseeing something, isn't

java {
    withSourcesJar()
    withJavadocJar()
}

missing? Especially gwt won't work without it

MrStahlfelge
MrStahlfelge requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@MrStahlfelge MrStahlfelge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • readme.md information to build from source does not apply any more, please change
  • gradlew test:html:superdev does not work

@Berstanio Berstanio requested a review from a team as a code owner December 26, 2024 11:31
@Berstanio
Copy link
Author

I think I addressed all issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonIT SimonIT SimonIT requested changes

@MrStahlfelge MrStahlfelge MrStahlfelge requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Berstanio @SimonIT @MrStahlfelge