Skip to content

Updating names to reflect purpose of the Object Action #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: async-action-changes
Choose a base branch
from

Conversation

jhanda
Copy link
Contributor

@jhanda jhanda commented Feb 26, 2025

@dnebing, the original naming scheme was confusing to me and didn't really reflect the intent of the CX action. This is an action that is manually triggered once an Application is submitted, reviewed and approved. It does create a User, but more importantly it creates a 'business' Account that represents the company that's completing the Distributor Application process.

@jhanda jhanda requested a review from dnebing February 26, 2025 23:05
@dnebing
Copy link
Contributor

dnebing commented Feb 26, 2025

I think it is okay to merge...

Just a nit: you could have used git mv UserCreatedRequest.java AccountCreationRequest.java would have retained the history instead of treating as a new file...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants